Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Rename shouldInitializeNativeSdk to autoInitializeNativeSdk #1275

Merged
merged 3 commits into from
Jan 13, 2021

Conversation

jennmueng
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Renames the option introduced in #1259 from shouldInitializeNativeSdk to autoInitializeNativeSdk.

💡 Motivation and Context

#1273 (comment)

💚 How did you test it?

Updated the existing test to test for autoInitializeNativeSdk

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes (Not breaking as we never released the former)

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jennmueng jennmueng merged commit 26f5268 into master Jan 13, 2021
@jennmueng jennmueng deleted the jenn/auto-init-native-rename branch January 13, 2021 09:27
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section under the following heading:

  1. feat: For new user-visible functionality.
  2. fix: For user-visible bug fixes.
  3. ref: For features, refactors and bug fixes in internal operations.

To the changelog entry, please add a link to this PR (consider a more descriptive message):

- Rename shouldInitializeNativeSdk to autoInitializeNativeSdk. (1275)

If none of the above apply, you can opt out by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 0d6b852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants